[18.0][IMP] queue_job: handle same uuid in duplicated db#852
Draft
hoangtrann wants to merge 1 commit intoOCA:18.0from
Draft
[18.0][IMP] queue_job: handle same uuid in duplicated db#852hoangtrann wants to merge 1 commit intoOCA:18.0from
hoangtrann wants to merge 1 commit intoOCA:18.0from
Conversation
Contributor
|
Hi @guewen, |
hoangtrann
force-pushed
the
18.0-fix-job-mismatch-db-name-after-db-duplication
branch
from
69a3b8e to
76d29bd
Compare
sbidoul
reviewed
Nov 22, 2025
| job.db_name, | ||
| db_name, | ||
| ) | ||
| self.remove_job(uuid) |
Member
There was a problem hiding this comment.
I'm not quite sure this is a correct thing to do. We still end up with two jobs with the same uuid in the queue and that's going to be confusing, if only when reading the logs. I suspect it will also break things down the line.
If that case is important to you, perhaps you could have a little script that updates uuid and dbname in the jobs of the cloned database?
sbidoul
requested changes
Nov 22, 2025
Member
sbidoul
left a comment
sbidoul
left a comment
There was a problem hiding this comment.
Another problem when duplicating a database is graph_uuid, which is also supposed to be unique.
So at this point I don't think this is an easy thing to support.
sbidoul
changed the title
Contributor
Author
|
that's fair point, let me think about this more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because jobrunner can be initialized with instance having multiple databases, cloning a db with failed jobs would cause the jobrunner to failed and causing jobs hang.